SOLR-17602 Exclude platform from generated pom #4039
Merged
+34
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
approved these changes
Jan 10, 2026
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
I assume you've tested somehow?
I 100% agree with your comment elsewhere that a Solr release smokeTest should include SolrJ dependency hello-world
Comment on lines
+158
to
+159
| def deps = dmNode.dependencies | ||
| if (deps) { |
Contributor
There was a problem hiding this comment.
Minor syntax recommendation but I love Groovy's elvis operator. Using it would remove an indentation level (lowering cyclomatic complexity) while keeping null-safety. Same above at depMgmt. I used to write a lot of Groovy back in the day.
janhoy
added a commit
that referenced
this pull request
Jan 11, 2026
(cherry picked from commit 07f111e)
janhoy
added a commit
that referenced
this pull request
Jan 11, 2026
(cherry picked from commit 07f111e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17602
Trying to fix the weird pom error I found in 10.0.0 RC1. I target it for SOLR-17602 since that was the (unreleased) issue introducing the platform module.